IndexHNSW support #47
Conversation
| describe('#constructor', () => { | ||
| it('1 arg will result in index with default neighbors & metric', () => { | ||
| const index = new IndexHNSW(2); | ||
| expect(index.getDimension()).toBe(2); |
There was a problem hiding this comment.
Ideally we'd be able to check the value of neighbors & metrics, but indexes don't expose those props so I kept this way for consistency with faiss. This check is only useful to show it doesn't throw.
|
Not sure I understand the build failures as IndexHNSW doesn't seem defined in the bindings somehow. Works great locally. Seems like it might be related to this command: It doesn't appear to actually be building, and instead using an older build artifact. Might be related to other build failures too. This is confirmed if you look at the unit test jobs which do pass because they're invoking a build. |
Yes, these two pipelines do use old build. The purpose is to confirm that the packages to be released can be installed and imported correctly in various environments. I would move these two builds to run on release(on push tags) rather than in every PR. (See :4b57bc4) |
This PR also includes new patterns for: